Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add better docs for density #1705

Merged
merged 1 commit into from
Aug 20, 2024
Merged

Add better docs for density #1705

merged 1 commit into from
Aug 20, 2024
+70 −0

Conversation

jessepinho
Copy link
Contributor

@jessepinho jessepinho commented Aug 17, 2024 •
edited
Loading

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Aug 17, 2024

⚠️ No Changeset found

Latest commit: 565885d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

Visit the preview URL for this PR (updated for commit 565885d):

https://penumbra-ui-preview--pr1705-jessepinho-density-d-phlvptoy.web.app

(expires Sat, 24 Aug 2024 02:58:30 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 709d729610ef7a6369b23f1cb2b820a60cc685b1

@grod220
Copy link
Collaborator

grod220 commented Aug 19, 2024

@VanishMax can you take this one over?

@VanishMax
Copy link
Contributor

@grod220 I will right after #1665

@jessepinho jessepinho marked this pull request as ready for review August 19, 2024 20:15
@jessepinho
Copy link
Contributor Author

Sorry yall, I accidentally left this in draft, but it's ready for review

@VanishMax VanishMax merged commit 29e896a into main Aug 20, 2024
8 checks passed
@VanishMax VanishMax deleted the jessepinho/density-docs branch August 20, 2024 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VanishMax VanishMax VanishMax approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add docblock to <Density /> component, explaining how to use it
3 participants
@jessepinho @grod220 @VanishMax